macos: glFlush() when switching GL contexts
authorChristian Hergert <chergert@redhat.com>
Thu, 26 Nov 2020 19:18:10 +0000 (11:18 -0800)
committerChristian Hergert <chergert@redhat.com>
Wed, 2 Dec 2020 00:19:04 +0000 (16:19 -0800)
The Mac OpenGL programming guide suggests that you glFlush() before changing
contexts to ensure that the commands have been submitted.

gdk/macos/gdkmacosglcontext.c

index 06829b9184c62d70b6bef803ceb5ce0659ea4fd7..00ddfefcdefaa2d21ca9a4237dcb2e9dbdd24c84 100644 (file)
@@ -447,15 +447,28 @@ _gdk_macos_gl_context_new (GdkMacosSurface  *surface,
 gboolean
 _gdk_macos_gl_context_make_current (GdkMacosGLContext *self)
 {
+  NSOpenGLContext *current;
+
   g_return_val_if_fail (GDK_IS_MACOS_GL_CONTEXT (self), FALSE);
 
-  if (self->gl_context != nil)
+  if (self->gl_context == NULL)
+    return FALSE;
+
+  current = [NSOpenGLContext currentContext];
+
+  if (self->gl_context != current)
     {
+      /* The OpenGL mac programming guide suggests that glFlush() is called
+       * before switching current contexts to ensure that the drawing commands
+       * are submitted.
+       */
+      if (current != NULL)
+        glFlush ();
+
       [self->gl_context makeCurrentContext];
-      return TRUE;
     }
 
-  return FALSE;
+  return TRUE;
 }
 
 G_GNUC_END_IGNORE_DEPRECATIONS